Skip to content

httpcaddyfile: Keep deprecated skip_log in directive order #6153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

steffenbusch
Copy link
Contributor

This small PR will add the deprecated skip_log directive back to the directive order to avoid this error:
`Error: adapting config using caddyfile: directive 'skip_log' is not an ordered HTTP handler, so it cannot be used here - try placing

See also:
#6066 (comment)

@francislavoie francislavoie changed the title Keep deprecated skip_log in directive order httpcaddyfile: Keep deprecated skip_log in directive order Mar 7, 2024
Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@francislavoie francislavoie added the bug 🐞 Something isn't working label Mar 7, 2024
@francislavoie francislavoie added this to the v2.8.0 milestone Mar 7, 2024
@francislavoie francislavoie merged commit c27425e into caddyserver:master Mar 7, 2024
dev-polymer pushed a commit to dev-polymer/caddy that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants