Skip to content

Sum of envelopes + example #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

RoccoRaimo
Copy link
Contributor

@RoccoRaimo RoccoRaimo commented May 16, 2024

Hi @ccaprani!
I've implemented the new method in class Envelopes to sum multiple envelopes, as described in #92, and included the example n.5 to show a possible usage scenario.

Let me know if everything is straight and clear!
Thanks.

RoccoRaimo and others added 4 commits May 9, 2024 14:48
Minor fix on bridge analysis plot envelopes. Bending moment was shown with negative sign and the y-axis was not inverted. Minor fix on "stress resultants".
As described in ccaprani#92, a new method has been implemented in class Envelopes to sum multiple envelopes. The example n.5 has been included to show a possible usage scenario.
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (9322c65) to head (8432283).
Report is 22 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   79.97%   84.38%   +4.41%     
==========================================
  Files          13       14       +1     
  Lines        1368     1684     +316     
==========================================
+ Hits         1094     1421     +327     
+ Misses        274      263      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@ccaprani ccaprani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 😃 I haven't yet looked at the notebook, but are there any tests that would make sense to add for the new functionality?

@RoccoRaimo
Copy link
Contributor Author

RoccoRaimo commented May 16, 2024

At the end of the example in the notebook I inserted a numerical control of the results between a "manual" sum of the results and the "automatic" one that comes with the use of the new function.
Don't know if it makes sense to create a separate test. Let me know once you'll look up at the notebook :)

@RoccoRaimo
Copy link
Contributor Author

Hi Colin! Have you had a look at the notebook with the example on it?

@RoccoRaimo RoccoRaimo requested a review from ccaprani April 10, 2025 10:01
@RoccoRaimo
Copy link
Contributor Author

Hi @ccaprani, I've added the file test_tesults.py that contains a test for sum of compatible envelopes and another one to verify if two incompatible envelopes are used (ex. 2 envelopes of results with different spans number). Let me know if it is enough to merge the pull request and update the package. Thanks!

@ccaprani
Copy link
Owner

Hi @RoccoRaimo - thank you so much for this. I made a few small tweaks on my local, but can't add to this PR. Can click "Allow edits from maintainers" please? You should see it on the PR from your view.

@RoccoRaimo
Copy link
Contributor Author

Hi @ccaprani, it was already checked. I unchecked and re-checked it, try now and let me know. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants