[refactor] Introduce BaseForwardModel #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 74.36% 74.59% +0.22%
==========================================
Files 74 75 +1
Lines 3125 3098 -27
==========================================
- Hits 2324 2311 -13
+ Misses 801 787 -14 |
mottodora
reviewed
Apr 13, 2018
| if device >= 0: | ||
| chainer.cuda.get_device_from_id(device).use() | ||
| self.to_gpu() # Copy the model to the GPU | ||
| self.initialize(device) |
There was a problem hiding this comment.
Please add same comment that is in Regressor
mottodora
approved these changes
Apr 13, 2018
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce BaseForwardModel
_forwardmethod_devicemanagementuser can update device of model by
update_devicemethod.This PR also resolves #134