Skip to content

Scale output labels in the QM9 example and refactor code. #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2018
Merged

Scale output labels in the QM9 example and refactor code. #256

merged 3 commits into from
Sep 1, 2018

Conversation

mihaimorariu
Copy link
Contributor

@mottodora Can you please review?

@mihaimorariu mihaimorariu requested a review from mottodora August 24, 2018 05:33
@codecov-io
Copy link

Codecov Report

Merging #256 into master will decrease coverage by 6.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage    88.8%   82.22%   -6.59%     
==========================================
  Files         112      112              
  Lines        5484     5484              
==========================================
- Hits         4870     4509     -361     
- Misses        614      975     +361

@mihaimorariu mihaimorariu changed the title Scale output labels and refactor code. Scale output labels in the QM9 example and refactor code. Aug 24, 2018
@corochann
Copy link
Member

LGTM, please review @mottodora

Copy link
Member

@mottodora mottodora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mottodora
Copy link
Member

I confirm scirpts run without error.

@mottodora mottodora merged commit c39367f into chainer:master Sep 1, 2018
@mihaimorariu mihaimorariu deleted the devel/qm9_example branch September 7, 2018 00:50
@corochann corochann added this to the 0.5.0 milestone Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants