Skip to content

Fix the type of return value from R2 Score Evaluator #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2019
Merged

Fix the type of return value from R2 Score Evaluator #339

merged 2 commits into from
Mar 11, 2019

Conversation

mottodora
Copy link
Member

No description provided.

@mottodora mottodora requested a review from natsukium March 11, 2019 05:11
@natsukium
Copy link
Collaborator

Could you fix test_r2_score_evaluator.py too?
Thank you for fixing my mistake.

@natsukium
Copy link
Collaborator

These indices is unnecessary.

https://github.com/pfnet-research/chainer-chemistry/blob/6de82de4cafd38a9826e68771432bff6ab01edc5/tests/training_tests/extensions_tests/test_r2_score_evaluator.py#L96

natsukium
natsukium approved these changes Mar 11, 2019
View reviewed changes
Copy link
Collaborator

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mottodora
Copy link
Member Author

Fixed.

@codecov-io
Copy link

Codecov Report

Merging #339 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   80.42%   80.42%           
=======================================
  Files         199      199           
  Lines        9069     9069           
=======================================
  Hits         7294     7294           
  Misses       1775     1775

@natsukium natsukium merged commit ec4ac7c into chainer:master Mar 11, 2019
@mottodora mottodora added this to the 0.6.0 milestone Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mottodora @natsukium @codecov-io