Graph film v2 #386
Merged
Graph film v2 #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
|
Successfully created a job for commit db195af: |
|
/test |
|
Successfully created a job for commit 85468da: |
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
- Coverage 91.42% 86.58% -4.84%
==========================================
Files 222 227 +5
Lines 10786 10988 +202
==========================================
- Hits 9861 9514 -347
- Misses 925 1474 +549 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
- Coverage 91.42% 86.58% -4.84%
==========================================
Files 222 227 +5
Lines 10786 10988 +202
==========================================
- Hits 9861 9514 -347
- Misses 925 1474 +549 |
|
/test |
|
Successfully created a job for commit 34a78d2: |
Closed
mottodora
requested changes
Sep 11, 2019
chainer_chemistry/models/gnn_film.py
Outdated
| activation (~chainer.Function or ~chainer.FunctionNode): | ||
| activate function | ||
| n_edge_types (int): number of edge type. | ||
| Defaults to 4 for single, double, triple and aromatic bond. |
There was a problem hiding this comment.
Defaults to 5 for single, double, triple, aromatic bond, and self-connection
| @@ -118,7 +118,7 @@ def construct_adj_matrix(mol, out_size=-1, self_connection=True): | |||
| return adj_array | |||
|
|
|||
|
|
|||
| def construct_discrete_edge_matrix(mol, out_size=-1): | |||
| def construct_discrete_edge_matrix(mol, out_size=-1, self_connection=False): | |||
There was a problem hiding this comment.
I prefer add_self_connection_channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.