dlopen: Add support for LLVM-14 typed pointers #27645
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Longnecker <[email protected]>
Signed-off-by: David Longnecker <[email protected]>
Signed-off-by: David Longnecker <[email protected]>
Signed-off-by: David Longnecker <[email protected]>
jabraham17
reviewed
Aug 13, 2025
compiler/codegen/cg-expr.cpp
Outdated
| val = info->irBuilder->CreateBitCast(val, fnPtrType); | ||
| #endif | ||
|
|
||
| if (!fnType) INT_FATAL("Need function type to create indirect call"); |
There was a problem hiding this comment.
this should probably go before the call to getUnqual
There was a problem hiding this comment.
Good catch, thanks.
Signed-off-by: David Longnecker <[email protected]>
jabraham17
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for older versions of LLVM that require typed pointers (currently the only version of LLVM we support that uses typed pointers by default is LLVM-14).
When issuing an indirect call we usually pass in a
void*storing the address of the local pointer. This PR just adds a bitcast instruction to the function pointer type when the macroHAVE_LLVM_TYPED_POINTERSis defined.We already do a similar thing when calling vtable pointers, so I found inspiration there.
I tested this with
LLVM-14onlinux64withCOMM=gasnetandCOMM=noneand all the procedure pointer tests seem to pass.Reviewed by @jabraham17. Thanks!