ci: Print hint to fix auto-generated file checks #13718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
area/CI
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
kkourt
approved these changes
Oct 23, 2020
|
Mark ready to merge as changes are only for github action (e.g. full ci is not required). |
sayboras
added
the
ready-to-merge
tklauser
reviewed
Oct 23, 2020
.github/workflows/smoke-test.yaml
Outdated
| @@ -47,7 +47,7 @@ jobs: | |||
| - name: Run helm-docs | |||
| run: | | |||
| make -C install/kubernetes docs | |||
| git diff --exit-code | |||
| git diff --exit-code || (echo "please run 'make -C install/kubernetes docs' and check in files"; exit 1) | |||
There was a problem hiding this comment.
Nit: all other messages say "...and submit your changes" here. Maybe change it as well to stay consistent?
Suggested change
| git diff --exit-code || (echo "please run 'make -C install/kubernetes docs' and check in files"; exit 1) | |
| git diff --exit-code || (echo "please run 'make -C install/kubernetes docs' and submit your changes"; exit 1) |
aanm
removed
the
ready-to-merge
This commit is to print step on how to fix github action check for generated files. This will surely help new contributors to have better experience and reduce feedback loop. Suggested by: Kornilios Kourtis <[email protected]> Signed-off-by: Tam Mach <[email protected]>
tklauser
approved these changes
Oct 23, 2020
kkourt
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ci(gha): Print hint to fix generated file check
This commit is to print steps on how to fix github action check for
generated files. This will surely help new contributors to have
better experience and reduce feedback loop.
Suggested by: Kornilios Kourtis [email protected]
Signed-off-by: Tam Mach [email protected]
Testing
Testing was done by one dummy change in one of the file https://github.com/cilium/cilium/pull/13718/checks?check_run_id=1296840070