-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix a typo in the comment example #21402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Actually looking into it more, it should be separated with spaces for it to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @farcaller and thank you for the PR!
Actually looking into it more, it should be separated with spaces for it to work. cobra is somewhat inconsistent in that regard, so I verified that on practice. Should I patch that in this same PR?
That make sense to me, please see also the required
helm message here, I think it needs s/logs/log/
and the example should be copied over to the values (possibly after fixing comma vs space).
To fix this CI failure, please edit your changes to install/kubernetes/cilium/values.yaml.tmpl
and then run make -C install/kubernetes cilium/values.yaml
to update install/kubernetes/cilium/values.yaml
.
Finally, pulling someone from the @cilium/api team to confirm the fixes.
It's `log` in the [config.go](https://github.com/cilium/cilium/blob/master/pkg/option/config.go#L988). Also fix the delimeter (the actual cli acceps the space but not a comma). Signed-off-by: Vladimir Pouzanov <[email protected]>
Done and done. |
/test |
It's
log
in the config.goSigned-off-by: Vladimir Pouzanov [email protected]
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes a typo in the comment example: it's
log
in the config.go