tetragon: Header file and other cleanups #1184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not used anymore. Signed-off-by: Jiri Olsa <[email protected]>
Current helpers in bpf_events.h contain task related helpers, so let's move them to bpf_task.h header. This way we can use bpf_event.h header for event related helpers in following changes. Signed-off-by: Jiri Olsa <[email protected]>
It's not used anywhere. Signed-off-by: Jiri Olsa <[email protected]>
Renaming hubble_msg.h header to bpf_event.h , so we get rid of the hubble name and have tcpmon_map map definition in bpf_event.h header. Signed-off-by: Jiri Olsa <[email protected]>
Keep just one BPF_F_CURRENT_CPU definition to prevent severe headaches for tetragon developers. Signed-off-by: Jiri Olsa <[email protected]>
ghost
reviewed
Jul 5, 2023
kkourt
approved these changes
Jul 6, 2023
| BPF_F_INDEX_MASK = -1, | ||
| BPF_F_CURRENT_CPU = -1, | ||
| BPF_F_INDEX_MASK = 0xffffffffULL, | ||
| BPF_F_CURRENT_CPU = BPF_F_INDEX_MASK, |
There was a problem hiding this comment.
Preventing severe headaches is appreciated! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing cleanups in extra PR to make the following PR small.