tetragon: Use lru.Cache for data events storage #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsajiri
force-pushed
the
data_events_fix
branch
4 times, most recently
from
38bd06d to
b549f4b
Compare
olsajiri
force-pushed
the
data_events_fix
branch
from
b549f4b to
2f46a5a
Compare
olsajiri
force-pushed
the
data_events_fix
branch
4 times, most recently
from
c37b2a6 to
fa44c1c
Compare
jrfastab
approved these changes
Jan 6, 2023
olsajiri
force-pushed
the
data_events_fix
branch
5 times, most recently
from
38a877b to
5b28739
Compare
|
@olsajiri maybe it's worth rebasing this one? |
olsajiri
force-pushed
the
data_events_fix
branch
4 times, most recently
from
8fbc14d to
83d8fd5
Compare
Moving data object to observer. It helps following change not to create golang dependency cycles when initializing data cache. Signed-off-by: Jiri Olsa <[email protected]>
There's a chance that by losing events (in perf ring buffer) we would never use data stored by data events. Adding the data into lru cache so we eventually remove unused entries to make space for new ones and don't grow endlessly. Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
force-pushed
the
data_events_fix
branch
from
83d8fd5 to
504f77b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a chance that by losing events (in perf ring buffer)
we would never use data stored by data events. Adding the data
into lru cache so we eventually remove unused entries to make
space for new ones and don't grow endlessly.
Signed-off-by: Jiri Olsa [email protected]