tetragon: fix graceful shutdown and exit code #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now tetragon always exit with 1, let's fix this and improve graceful shutdown, so service monitors and container managers... won't treat Tetragon as it failed. Some start up logic was re-ordered to improve how we cleanup things. Also this change will make tetragonExecute() return up to callers, and allow Tetragon main to exit with 0. Signed-off-by: Djalal Harouni <[email protected]>
tixxdz
force-pushed
the
pr/tixxdz/improve-signal-handling
branch
from
01c3ac2 to
f65d93d
Compare
kkourt
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now tetragon always exit with 1, let's fix this and improve graceful shutdown, so service monitors and container managers... won't treat Tetragon as it failed.
Some start up logic was re-ordered to improve how we cleanup things.
Also this change will make tetragonExecute() return up to callers, and allow Tetragon main to exit with 0.
Signed-off-by: Djalal Harouni [email protected]