tetragon: Check and remove not compatible map pin paths on loading #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yep needs to pass testing but certainly good to have. |
sure, it needs the cilium/ebpf change first cilium/ebpf#854 |
got merged, meanwhile I added tetragon local version of that |
Checking the compatibility of pinned map before loading the map from it. If map is not compatible with pinned map file, remove the pin and create the map from scratch. We will use MapSpec.Compatible in future, which will be exported in cilium/ebpf v0.9.3, meanwhile steal that and make it our own. Adding following warning to the logs: ... time="2022-11-25T10:41:46+01:00" level=info msg="tetragon, map loaded." map=execve_map path=/sys/fs/bpf/tetragon/execve_map sensor=__base__ time="2022-11-25T10:41:46+01:00" level=warning msg="tetragon, incompatible map found: expected type PerCPUArray, got Array: map spec is incompatible with existing map" map=execve_map_stats path=/sys/fs/bpf/tetragon/execve_map_stats sensor=__base__ ... Signed-off-by: Jiri Olsa <[email protected]>
kkourt
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following cilium/ebpf interface creates map from pin path
and checks if the pin is compatible with the map spec:
ebpf.NewMapWithOptions(spec, ebpf.MapOptions{PinPath: path, FullPath: true})
use that in the sensors map loading code
TODO split the cilium/ebpf change and push it separately
Signed-off-by: Jiri Olsa [email protected]