tetragon: fix initialization deadlock #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
force-pushed
the
pr/kkourt/init-config-deadlock
branch
2 times, most recently
from
632b453 to
251122a
Compare
There is a potential for a deadlock in the initialization case. This might happen if, for example, we pass a wrong filename for the config file. We fix this by generating a new context which we can cancel without causing deadlocks. The patch also adds comments to explain why this is needed so more details can be found there. Reported-by: Zhiyu Wang <[email protected]> Signed-off-by: Djalal Harouni <[email protected]> Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/init-config-deadlock
branch
from
251122a to
9214209
Compare
tixxdz
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a potential for a deadlock in the initialization case. This might happen if, for example, we pass a wrong filename for the config file.
We fix this by generating a new context which we can cancel without causing deadlocks.
The patch also adds comments to explain why this is needed so more details can be found there.
Signed-off-by: Djalal Harouni [email protected]
Signed-off-by: Kornilios Kourtis [email protected]
Reported-by: Zhiyu Wang [email protected]