-
Notifications
You must be signed in to change notification settings - Fork 442
tetragon: tarball deployment #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f98d49
to
dab135c
Compare
98c10ec
to
782c0d8
Compare
olsajiri
reviewed
Jan 19, 2023
olsajiri
reviewed
Jan 23, 2023
kkourt
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming @olsajiri's feedback is addressed.
Thanks! (especially for the nice documentation!)
olsajiri
approved these changes
Jan 23, 2023
1f67c23
to
968be86
Compare
When building tarballs we want to produce files in following format: tetragon-$(version)-{amd64|arm64}.tar.gz, to achieve this let's set some architecture variables inside make. Define exported TARGET_ARCH as the main target architecture of main Makefile, and use BPF_TARGET_ARCH to set the BPF ARCH. While we are it add an non exported ARCH var that defaults to amd64 for Golang binaries. For arm64/aarch64 builds setting this to arm64 should just work. For bpf the corresponding BPF_TARGET_ARCH=arm64 must also be set, this can be achieved by getting parent TARGET_ARCH value. Signed-off-by: Djalal Harouni <[email protected]>
968be86
to
7a17a45
Compare
This adds the linux-tarball deployment resource files with their Dockerfile.tarball file to make a docker image with one layer that can be dumped to a tar -> tar.gz Include sane and secure configurations for a non k8s deployment. Signed-off-by: Djalal Harouni <[email protected]>
This explicitly uses make image as a base so we have same workflow. Signed-off-by: Djalal Harouni <[email protected]>
Signed-off-by: Djalal Harouni <[email protected]>
7a17a45
to
ae2d3ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Djalal Harouni [email protected]