eventchecker: implement checker names #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willfindlay
force-pushed
the
pr/willfindlay/eventchecker-names
branch
from
bdb1a9c to
111c610
Compare
This commit implments eventchecker names for top-level checkers (i.e. checkers that check a process event). These names will show up in the error logs when a check fails. That should hopefully improve the readability of test logs (especially e2e tests) and help us diagnose why tests are failing. Note that for most of the tests that have only one checker, I have opted to give them an empty name. This is because these are cases where disambiguation is (obviously) unhelpful. For some practical examples of why this construct is actually useful, please refer to the end-to-end tests. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/eventchecker-names
branch
from
111c610 to
0e2ebcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implments eventchecker names for top-level checkers (i.e. checkers that check a process event). These names will show up in the error logs when a check fails. That should hopefully improve the readability of test logs (especially e2e tests) and help us diagnose why tests are failing.
Note that for most of the tests that have only one checker, I have opted to give them an empty name. This is because these are cases where disambiguation is (obviously) unhelpful. For some practical examples of why this construct is actually useful, please refer to the end-to-end tests.
Signed-off-by: William Findlay [email protected]