Skip to content

pkg/config: print name in validation error #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

pkg/config: print name in validation error #670

merged 1 commit into from
Jan 30, 2023

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Jan 30, 2023

I forgot to add that and it would have helped me a lot to debug errors...

@mtardy mtardy requested a review from a team as a code owner January 30, 2023 15:04
@mtardy mtardy requested a review from jrfastab January 30, 2023 15:04
@mtardy mtardy force-pushed the pr/mtardy/pkg-config-validation branch from cc8199c to e495a32 Compare January 30, 2023 15:05
willfindlay
willfindlay approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@willfindlay willfindlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems innocent enough

@mtardy mtardy added kind/enhancement This improves or streamlines existing functionality go Pull requests that update Go code labels Jan 30, 2023
@mtardy mtardy merged commit 02ce4ee into main Jan 30, 2023
@mtardy mtardy deleted the pr/mtardy/pkg-config-validation branch January 30, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfastab jrfastab Awaiting requested review from jrfastab jrfastab is a code owner automatically assigned from cilium/tetragon

1 more reviewer

@willfindlay willfindlay willfindlay approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
go Pull requests that update Go code kind/enhancement This improves or streamlines existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtardy @willfindlay