tests/e2e: add ability to reset checker limits and retry demo app installation #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, we want to the ability to retry tests when specific setup conditions fail. For example, this might happen when a helm deployment fails to install and we would like to try again without the checker timing out. Signed-off-by: William Findlay <[email protected]>
The demo app can sometimes fail to install correctly. If that happens, let's try again. Signed-off-by: William Findlay <[email protected]>
jrfastab
approved these changes
Feb 4, 2023
|
I think this is OK we likely wont had any bugs with retries here because we are retrying the install of other things, not tetragon? |
|
@jrfastab correct. Basically, the issue is that we sometimes got eventchecker failures that weren't our fault because the demo app wasn't installing correctly. This will only retry when that installation fails, so we won't be missing legitimate failures. |
tixxdz
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve a rare CI failure caused by the demo app failing to install correctly.