data: silence annoying debug log messages #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tixxdz
approved these changes
Feb 2, 2023
The "Data message received" and "Data message used" log messages flood the Tetragon logs when debug logging is enabled, to the point that it obfuscates all other debug messages. Bump these messages up to the trace level so that they are less annoying. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/silence-data-logs
branch
from
b41cf99 to
c43afa6
Compare
kkourt
reviewed
Feb 8, 2023
| @@ -45,7 +45,7 @@ func add(r *bytes.Reader, m *dataapi.MsgData) error { | |||
| dataMap.Add(m.Id, data) | |||
| } | |||
|
|
|||
| logger.GetLogger().Debugf("Data message received id %v, size %v, total %v", m.Id, size, len(data)) | |||
| logger.GetLogger().WithFields(nil).Tracef("Data message received id %v, size %v, total %v", m.Id, size, len(data)) | |||
There was a problem hiding this comment.
I guess the WithFields can be removed? Or is the idea to encode the fields there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Data message received" and "Data message used" log messages flood the Tetragon logs when debug logging is enabled, to the point that it obfuscates all other debug messages. Bump these messages up to the trace level so that they are less annoying.
Signed-off-by: William Findlay [email protected]