Skip to content

Add a Tetragon documentation website and rename base folder crds into examples #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Mar 8, 2023

This website is not finished, the goal is to merge it "as-is", not advertising it for now, finish the home page and branding and then advertise it!

When merging this, I need some manual steps to be performed on the repository settings to configure the GitHub page.

The main pain point that need to be addressed is that currently, this PR breaks the soft links that were made to the existing documentation that moved. Including examples from @sharlns and Jed report.

  • Note for myself, remove the useless 400kb cereal image even if it might be too late :/

@mtardy mtardy added the area/documentation Improvements or additions to documentation label Mar 8, 2023
@mtardy mtardy requested review from willfindlay and a team as code owners March 8, 2023 18:05
@xmulligan
Copy link
Member

do we have any stats on how often the links are used?

Copy link
Contributor

@willfindlay willfindlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI changes LGTM. Do we want to add a protection rule for the github-pages environment?

@mtardy
Copy link
Member Author

mtardy commented Mar 9, 2023

Thanks for looking at the CI changes :)

Do we want to add a protection rule for the github-pages environment?

It shouldn't be needed, just merging = approved => deployed on the website. wdyt?

@mtardy
Copy link
Member Author

mtardy commented Mar 9, 2023

do we have any stats on how often the links are used?

I really don't know but the report is still being actively distributed and it would be as easy as replacing the link redirection to permalinks I guess so, it would be nice to do it before moving this stuff. This is a blocker and we need to solve this before merging.

@mtardy mtardy force-pushed the pr/mtardy/docs-website branch from 52a6d2b to 1268c18 Compare March 9, 2023 16:13
@mtardy
Copy link
Member Author

mtardy commented Mar 9, 2023

For now, the easiest decision is to not delete it. So I just left docs/security-observability-with-ebpf intact, even if it looks weird.

One downside I overlooked as well is that I am deleting @tixxdz example configuration folder: https://github.com/cilium/tetragon/tree/main/docs/configuration/tetragon.conf.d. Maybe I could move it under docs/examples/configuration/tetragon.conf.d?

@willfindlay
Copy link
Contributor

willfindlay commented Mar 9, 2023

We already have /examples, can we just move the tetragon.conf.d magic into there?

@mtardy
Copy link
Member Author

mtardy commented Mar 9, 2023

We already have /examples, can we just move the tetragon.conf.d magic into there?

@willfindlay do you mean /crds/examples? I don't think we have a root level /examples folder. Although it would make way more sense to rename crds to examples and put things in like configuration, tracingpolicy, etc...

@willfindlay
Copy link
Contributor

Yeah sorry that's what I meant.

Although it would make way more sense to rename crds to examples and put things in like configuration, tracingpolicy, etc...

Yeah I like this as an idea. Especially because they're not really CRDs...

@mtardy
Copy link
Member Author

mtardy commented Mar 9, 2023

Yeah sorry that's what I meant.

Although it would make way more sense to rename crds to examples and put things in like configuration, tracingpolicy, etc...

Yeah I like this as an idea. Especially because they're not really CRDs...

+1000, it just confuses everybody and then we are all saying CRD all the time instead of CR or TracingPolicy!

@mtardy mtardy force-pushed the pr/mtardy/docs-website branch from 1268c18 to c67709e Compare March 10, 2023 11:37
@mtardy mtardy changed the title Add a Tetragon documentation website Add a Tetragon documentation website and rename base folder crds into examples Mar 10, 2023
@mtardy mtardy force-pushed the pr/mtardy/docs-website branch from c67709e to 066d532 Compare March 10, 2023 11:40
@mtardy
Copy link
Member Author

mtardy commented Mar 10, 2023

So now this PR does a bit more than intended:

  • Add the documentation website.
  • Rename the crds top folder into examples.
  • Keep docs/security-observability-with-ebpf/ in place (to not break printed links in the printed report).

Please look at the individual commits to review, it will be easier, especially for the renaming step.

This PR will break the link to documentation like https://github.com/cilium/tetragon/blob/main/docs/tracingpolicy/README.md, this is intended because we will then redirect people to the properly built website documentation when this thing merges.

@mtardy mtardy force-pushed the pr/mtardy/docs-website branch from 066d532 to a1f5a57 Compare March 10, 2023 11:52
mtardy added 3 commits March 10, 2023 14:49
Also add a paths-ignore to most workflows in order to skip code related
workflows on docs changes. See the following link for more information:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-excluding-paths

Signed-off-by: Mahe Tardy <[email protected]>
- mostly rename 'crds' into 'examples' and thus replace 'crds/examples'
  with 'examples/tracingpolicy' and simplify other directory structure
  under 'examples'.
- fix all the links available in the repository from docs and code to
  point to the new 'examples' hierarchy instead of the old ones.
- move the configuration dir struct example from 'docs/configuration' to
  'examples/configuration'.
- remove the symbolic link to the CRD definition yaml.
- update the README of the new 'examples' folder.

Signed-off-by: Mahe Tardy <[email protected]>
@mtardy mtardy force-pushed the pr/mtardy/docs-website branch from a1f5a57 to 8d48096 Compare March 10, 2023 13:49
@kkourt kkourt merged commit de062c5 into main Mar 10, 2023
@kkourt kkourt deleted the pr/mtardy/docs-website branch March 10, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants