Skip to content

tetragon: Add --force-large-progs option to force large bpf programs #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

olsajiri
Copy link
Contributor

Adding --force-large-progs option to force loading of large bpf
programs.

It's usefull in situations where kernel contains backports and
its version does not reflect actual features.

Signed-off-by: Jiri Olsa [email protected]

@olsajiri olsajiri marked this pull request as ready for review March 12, 2023 18:43
@olsajiri olsajiri requested a review from a team as a code owner March 12, 2023 18:43
@olsajiri olsajiri requested a review from jrfastab March 12, 2023 18:43
Copy link
Member

@tixxdz tixxdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How disruptive is to try to load large programs by default even on old kernels and if it fails fallback to small programs? or a bpf feature / probe test? I'm asking in case we can avoid adding a new command line parameter , otherwise fine!

Btw do we have info log messages that can note:

  1. Force loading small programs on kernels >= 5.3
  2. Force loading large programs on old kernels

Approved but would be great if we can do those ;-)

@olsajiri
Copy link
Contributor Author

How disruptive is to try to load large programs by default even on old kernels and if it fails fallback to small programs? or a bpf feature / probe test? I'm asking in case we can avoid adding a new command line parameter , otherwise fine!

I'd think the standard 4.18 kernel will have expected features.. it's just rhel that I know of with far upstream backports,
I'd keep loading the small programs first.. and have user to decide to force large programs

Btw do we have info log messages that can note:

1. Force loading small programs on kernels >= 5.3

2. Force loading large programs on old kernels

good idea, I'll put some log message

Adding --force-large-progs option to force loading of large bpf
programs.

It's useful in situations where kernel contains backports and its version
does not reflect actuall features.

Also adding log message for both --force-small-progs/force-large-progs
options.

Signed-off-by: Jiri Olsa <[email protected]>
Adding sigkill tracing policy example that catches writes like:

    $ echo "krava" > /tmp/passwd

Signed-off-by: Jiri Olsa <[email protected]>
@netlify
Copy link

netlify bot commented Mar 29, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit ede452f
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6424a8283d9b2a000802866d
😎 Deploy Preview https://deploy-preview-795--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kkourt kkourt merged commit 7ae38e0 into cilium:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants