-
Notifications
You must be signed in to change notification settings - Fork 442
docs: missing space indent #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, welcome to Tetragon! Mmh what makes you think there are missing space indents in these examples? I don't think your fix is correct.
@mtardy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, you are correct sorry indeed. Have you addressed all of them?
@mtardy I just reviewed it for the third time. look like that's all of it. |
Thanks a lot for taking the time, one more nit I'm sorry and it involves git, could you squash your commits into one with a message like "docs: fix indentation inconsistencies across TracingPolicy examples" and sign with a real email address? See https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together and https://docs.pi-hole.net/guides/github/how-to-signoff/ if you need help. |
6ab8b2f
to
28a92ae
Compare
@mtardy fixed commit message and signed with a real email |
Thanks a lot the squash and message are perfect, the commit still misses the signed-off line in the message. |
Signed-off-by: Jinna C <[email protected]>
@mtardy Oh done please check again. This is my first time :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtardy Oh done please check again. This is my first time :)
No worries, now you learned how to squash commits and amend the message to rectify the message and the signature which is very useful. Thanks for your PR.
I found some missing indent in document