Skip to content

docs: missing space indent #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2023
Merged

docs: missing space indent #809

merged 1 commit into from
Mar 16, 2023

Conversation

cjtim
Copy link
Contributor

@cjtim cjtim commented Mar 16, 2023

I found some missing indent in document

@cjtim cjtim requested a review from a team as a code owner March 16, 2023 06:36
@cjtim cjtim requested a review from kevsecurity March 16, 2023 06:36
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, welcome to Tetragon! Mmh what makes you think there are missing space indents in these examples? I don't think your fix is correct.

@cjtim
Copy link
Contributor Author

cjtim commented Mar 16, 2023

Hey, welcome to Tetragon! Mmh what makes you think there are missing space indents in these examples? I don't think your fix is correct.

@mtardy
there are inconsistent space across same document

https://github.com/cilium/tetragon/pull/809/files#diff-cb2007a8853b538bf3423def3ca65bc7a057c3ed57485a3ff360ba50df7ed31cR253-R261

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, you are correct sorry indeed. Have you addressed all of them?

@cjtim
Copy link
Contributor Author

cjtim commented Mar 16, 2023

@mtardy I just reviewed it for the third time. look like that's all of it.

@mtardy
Copy link
Member

mtardy commented Mar 16, 2023

@mtardy I just reviewed it for the third time. look like that's all of it.

Thanks a lot for taking the time, one more nit I'm sorry and it involves git, could you squash your commits into one with a message like "docs: fix indentation inconsistencies across TracingPolicy examples" and sign with a real email address?

See https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together and https://docs.pi-hole.net/guides/github/how-to-signoff/ if you need help.

@mtardy mtardy added the area/documentation Improvements or additions to documentation label Mar 16, 2023
@cjtim cjtim force-pushed the patch-1 branch 2 times, most recently from 6ab8b2f to 28a92ae Compare March 16, 2023 10:08
@cjtim
Copy link
Contributor Author

cjtim commented Mar 16, 2023

@mtardy fixed commit message and signed with a real email

@mtardy
Copy link
Member

mtardy commented Mar 16, 2023

@mtardy fixed commit message and signed with a real email

Thanks a lot the squash and message are perfect, the commit still misses the signed-off line in the message.

@cjtim
Copy link
Contributor Author

cjtim commented Mar 16, 2023

@mtardy Oh done please check again. This is my first time :)

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtardy Oh done please check again. This is my first time :)

No worries, now you learned how to squash commits and amend the message to rectify the message and the signature which is very useful. Thanks for your PR.

@mtardy mtardy merged commit 7808890 into cilium:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants