Skip to content

ignore .idea #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2023
Merged

ignore .idea #829

merged 1 commit into from
Mar 28, 2023

Conversation

zhy76
Copy link
Contributor

@zhy76 zhy76 commented Mar 22, 2023

ignore .idea which is for IntellJ files

@zhy76 zhy76 requested a review from a team as a code owner March 22, 2023 02:06
@zhy76 zhy76 requested a review from jrfastab March 22, 2023 02:06
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thanks for the patch!

From a quick search it seems that the .idea folder is for IntelliJ specific files. Since we already have a .vscode file there, the change makes sense to me.

Could you please:

Thanks!

@zhy76
Copy link
Contributor Author

zhy76 commented Mar 28, 2023

Hi!

Thanks for the patch!

From a quick search it seems that the .idea folder is for IntelliJ specific files. Since we already have a .vscode file there, the change makes sense to me.

Could you please:

Thanks!

Sure!

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 595b412
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6422c3b87861e30008c129e9
😎 Deploy Preview https://deploy-preview-829--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zhy76
Copy link
Contributor Author

zhy76 commented Mar 28, 2023

PTAL, Thanks! @kkourt

Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kkourt kkourt merged commit 1931d94 into cilium:main Mar 28, 2023
@kkourt
Copy link
Contributor

kkourt commented Mar 28, 2023

(this is a simple change, no need to run tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants