Do not remove totaltime instrumentation from queryDesc #8029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8029 +/- ##
===========================================
- Coverage 89.19% 62.97% -26.23%
===========================================
Files 284 284
Lines 61515 61289 -226
Branches 7696 7641 -55
===========================================
- Hits 54871 38594 -16277
- Misses 4440 19855 +15415
- Partials 2204 2840 +636 🚀 New features to boost your workflow:
|
Green-Chan
force-pushed
the
do-not-remove-totaltime
branch
from
faac9b9 to
6e35220
Compare
Green-Chan
force-pushed
the
do-not-remove-totaltime
branch
from
6e35220 to
86bd65c
Compare
Green-Chan
force-pushed
the
do-not-remove-totaltime
branch
from
86bd65c to
df771e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous approach could have caused problems with other extensions that are using queryDesc->totaltime during query execution. Use another way to count the time used before postgres' executor.