Add commitlog knobs to server config#5074
Merged
Merged
Conversation
kim
reviewed
May 20, 2026
kim
left a comment
kim
left a comment
Contributor
There was a problem hiding this comment.
The change is fine by me, but I'll note that commitlog config is exposed in the other edition, too, under a different key. It is probably not a good idea to let the config.toml diverge unless we have a good reason.
Also note that there is docs/docs/00300-resources/00200-reference/00100-cli-reference/00200-standalone-config.md, which I think should reflect these settings, even if they're deemed unstable.
kim
approved these changes
May 20, 2026
joshua-spacetime
removed this pull request from the merge queue due to a manual request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds the commitlog knobs
max_segment_size,write_buffer_size, andpreallocate_segmentsto the server'sconfig.toml. There are other seemingly more advanced knobs that I did not add at this time.This patch also increases the
DEFAULT_WRITE_BUFFER_SIZEfrom8KiBto128KiBto optimize high throughput workloads like the keynote-2 benchmark.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
Manual