fix: prioritize custom validator #1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1316 +/- ##
===========================================
- Coverage 72.80% 72.80% -0.01%
===========================================
Files 139 139
Lines 16244 16247 +3
===========================================
+ Hits 11826 11828 +2
- Misses 3823 3824 +1
Partials 595 595 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiaost
reviewed
Mar 28, 2025
pkg/route/engine.go
Outdated
| @@ -607,6 +610,10 @@ func (engine *Engine) initBinderAndValidator(opt *config.Options) { | |||
| if !ok { | |||
| panic("opt.BindConfig is not the '*binding.BindConfig' type") | |||
| } | |||
| // optimize: user customized validator has the highest priority | |||
| if isCustomValidator { | |||
There was a problem hiding this comment.
if isCustomValidator || bConf.Validator == nil {
FGYFFFF
force-pushed
the
feat/optimize_validate_cfg
branch
2 times, most recently
from
2067fa2 to
2275077
Compare
xiaost
changed the title
xiaost
force-pushed
the
feat/optimize_validate_cfg
branch
from
2275077 to
28eb582
Compare
xiaost
approved these changes
Apr 14, 2025
YangruiEmma
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1314
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
之前的设计是 Binder 和 Validator 是两个独立的组件，Binder 拥有自己的 Validator，配合进行 ctx.bindAndValidate()；而 binder 只作用于 ctx.Validate()。
根据用户反馈这么做有些反直觉，因此将这个配置做一个优化，如果用户自定义了 Validator (包括修改配置和设置自定义 Validator)，那么Binder 就优先使用这个自定义的 Validator。
(Optional) Which issue(s) this PR fixes:
(Optional) The PR that updates user documentation: