Skip to content

optimize(tool): remove apache replace in go.mod because apache thrift is not used anymore #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HeyJavaBean
Copy link
Member

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@HeyJavaBean HeyJavaBean requested review from a team as code owners June 19, 2025 04:04
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (918985c) to head (ea9f62c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1798      +/-   ##
==========================================
- Coverage   60.46%   60.39%   -0.08%     
==========================================
  Files         381      381              
  Lines       34515    34515              
==========================================
- Hits        20870    20844      -26     
- Misses      12373    12394      +21     
- Partials     1272     1277       +5     
Flag Coverage Δ
integration 48.20% <ø> (-0.17%) ⬇️
unit 50.83% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HeyJavaBean HeyJavaBean merged commit fefa17d into cloudwego:main Jun 19, 2025
22 of 23 checks passed
@HeyJavaBean HeyJavaBean changed the title optimize: remove apache replace in go.mod because apache thrift is not used anymore optimize(tool): remove apache replace in go.mod because apache thrift is not used anymore Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants