fix: support monorepo hoisted dependencies in JS requirements check

[mohammedahmed18]

Problem

The verify_requirements() method in JavaScript support only checked for test frameworks (jest/vitest) in the local package's node_modules. In monorepos with workspace dependency hoisting (yarn workspaces, pnpm workspaces, etc.), dependencies are often installed at the workspace root instead of in each package.

This caused false positive warnings like:

WARNING  JavaScript requirements check found issues:
WARNING    - jest is not installed. Please run 'npm install --save-dev jest' to install it.

Even though jest was properly installed at the workspace root.

Solution

• Check both local node_modules and workspace root node_modules
• Use existing _find_monorepo_root() helper to locate workspace root
• Add debug logging to show where framework was found
• Update docstring to document monorepo support

Testing

Tested with Budibase monorepo where jest is installed at:

• ❌ /home/ubuntu/budibase/packages/shared-core/node_modules/jest (doesn't exist)
• ✅ /home/ubuntu/budibase/node_modules/jest (workspace root - now detected)

Related

This complements the monorepo support already added to:

• jest-runner resolution in loop-runner.js
• Jest benchmarking in test_runner.py

[claude]

PR Review Summary

✅ Prek Checks

All linting and formatting checks passed successfully. No issues found.

✅ Mypy Type Checks

The changed lines in this PR do not introduce any new type errors. All mypy errors reported are pre-existing issues in the codebase and are unrelated to this PR's changes.

📋 Code Review

Status: No critical issues found

This PR successfully adds monorepo support for hoisted dependencies in JavaScript requirements checking. The implementation:

1. ✅ New function find_node_modules_with_package() (init_javascript.py:149-172)

   • Well-documented with clear docstring
   • Properly searches up the directory tree for node_modules
   • Returns Path | None appropriately
   • Clean implementation with no issues

2. ✅ Modified verify_requirements() method (support.py:1846-1905)

   • Uses the new helper function correctly
   • Maintains backward compatibility
   • Adds debug logging for visibility
   • Error messages are preserved and appropriate

Existing Review Comments:

• One comment marked as "✅ Fixed in latest commit" - the helper function was successfully moved to init_javascript.py
• One comment about missing test coverage remains open (see coverage analysis below)

📊 Test Coverage Analysis

File	Main Branch	This PR	Change
codeflash/cli_cmds/init_javascript.py	29.9%	41.1%	+11.2% ✅
codeflash/languages/javascript/support.py	71.2%	73.6%	+2.4% ✅
Overall Coverage	78.84%	78.98%	+0.14% ✅

Coverage Details:

• ✅ NEW function find_node_modules_with_package(): All code paths are executed by existing tests
  • Lines 149, 164-172 are covered
  • The function is properly tested through the verify_requirements() method calls
• ✅ MODIFIED verify_requirements() method: Most changes are covered
  • Lines 1880, 1881, 1887, 1889-1891, 1894-1896, 1900, 1905 are covered
  • The new monorepo fallback logic is exercised

Coverage Assessment:

• ✅ No coverage regression - overall coverage increased by +0.14%
• ✅ Modified code is well-covered by existing tests
• ⚠️ While the new function is covered by existing tests, the specific monorepo scenario (workspace root with hoisted dependencies) could benefit from an explicit test case as noted in the previous review comment

🔀 Codeflash Optimization PRs

Checked 30 open optimization PRs from codeflash-ai[bot]. None are ready to merge - all have failing CI checks (unit tests, type checks, or pr-review failures).

---

Last updated: 2026-02-04

[Saga4]

✅ Fixed in latest commit - moved to init_javascript.py as find_node_modules_with_package()

[claude]

⚠️ Missing test coverage: This monorepo fallback logic is not covered by any tests.

The existing tests in test_javascript_requirements.py only verify the case where the test framework is in local node_modules. Consider adding a test case like:

def test_verify_requirements_monorepo_hoisted_dependencies(self, js_support, tmp_path):
    """Test that frameworks in workspace root node_modules are detected."""
    # Create package without local node_modules
    package_root = tmp_path / "packages" / "shared-core"
    package_root.mkdir(parents=True)
    
    # Create workspace root with jest
    workspace_node_modules = tmp_path / "node_modules"
    workspace_node_modules.mkdir()
    (workspace_node_modules / "jest").mkdir()
    
    # Add workspace marker (e.g., yarn.lock)
    (tmp_path / "yarn.lock").touch()
    
    with patch("subprocess.run") as mock_run:
        mock_run.return_value = MagicMock(returncode=0)
        
        success, errors = js_support.verify_requirements(package_root, "jest")
        
        assert success is True
        assert errors == []

This would ensure the monorepo support actually works as intended.