selfdrived: surface processNotRunning alert when not engaged#38212
Open
ChenSiyun1234 wants to merge 2 commits into
Open
selfdrived: surface processNotRunning alert when not engaged#38212ChenSiyun1234 wants to merge 2 commits into
ChenSiyun1234 wants to merge 2 commits into
Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
e8d2fd8 to
74c0309
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34751.
When a process crashes,
processNotRunningis raised correctly, but it only hadNO_ENTRYandSOFT_DISABLEalerts, noPERMANENTone. So when you're not engaged, the screen shows thePERMANENTalert of some downstream fault instead (e.g.steerUnavailable's "LKAS Fault: Restart the car to engage"), which hides the real reason and sends you down the wrong path when debugging. That's exactly what happened in the issue.This adds a
PERMANENTalert forprocessNotRunning, atPriority.LOWon purpose:LOWER), so the real cause shows when not engaged, butMID), so it never hides the take-control warning if a process dies while engaged.Added two regression tests in
test_alerts.py: one checksprocessNotRunningwins oversteerUnavailablewhen not engaged, the other checks it does NOT mask the soft-disable alert when engaged.pytest selfdrive/selfdrived/tests/test_alerts.pypasses.