Skip to content

selfdrived: surface processNotRunning alert when not engaged#38212

Open
ChenSiyun1234 wants to merge 2 commits into
commaai:masterfrom
ChenSiyun1234:fix-process-not-running-shadowed
Open

selfdrived: surface processNotRunning alert when not engaged#38212
ChenSiyun1234 wants to merge 2 commits into
commaai:masterfrom
ChenSiyun1234:fix-process-not-running-shadowed

Conversation

@ChenSiyun1234

Copy link
Copy Markdown

Fixes #34751.

When a process crashes, processNotRunning is raised correctly, but it only had NO_ENTRY and SOFT_DISABLE alerts, no PERMANENT one. So when you're not engaged, the screen shows the PERMANENT alert of some downstream fault instead (e.g. steerUnavailable's "LKAS Fault: Restart the car to engage"), which hides the real reason and sends you down the wrong path when debugging. That's exactly what happened in the issue.

This adds a PERMANENT alert for processNotRunning, at Priority.LOW on purpose:

  • above the downstream fault's permanent alert (LOWER), so the real cause shows when not engaged, but
  • below the soft-disable "TAKE CONTROL IMMEDIATELY" alert (MID), so it never hides the take-control warning if a process dies while engaged.

Added two regression tests in test_alerts.py: one checks processNotRunning wins over steerUnavailable when not engaged, the other checks it does NOT mask the soft-disable alert when engaged. pytest selfdrive/selfdrived/tests/test_alerts.py passes.

@github-actions

github-actions Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Process replay diff report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

✅ 0 changed, 66 passed, 0 errors

@ChenSiyun1234 ChenSiyun1234 force-pushed the fix-process-not-running-shadowed branch from e8d2fd8 to 74c0309 Compare June 22, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

process not running alert can be shadowed

1 participant