longitudinal: move cruise speed limit out of the MPC#38232
Open
haraschax wants to merge 1 commit into
Open
Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. Show changes |
Contributor
|
I was working on a report for this. You have one too or just want to ship as it's more correct anyway? |
Contributor
Author
|
The mpc_longitudinal_tuning_report.py should be pretty complete already |
264978f to
c27a288
Compare
ae02710 to
f8478df
Compare
The cruise speed limit is now applied in the planner instead of as a fake obstacle inside the MPC. The MPC only plans around lead obstacles, and the planner applies a rate-limited cruise acceleration limit. - long_mpc.py: remove v_cruise param, cruise obstacle, CRUISE_*_ACCEL constants, and cruise from MPC_SOURCES - longitudinal_planner.py: apply rate-limited cruise acceleration limit outside the MPC and take the min with the MPC output
f8478df to
485fe9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.