Skip to content

python3.sif: containerize tools #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2025
Merged

python3.sif: containerize tools #303

merged 5 commits into from
Mar 27, 2025

Conversation

espenhgn
Copy link
Contributor

@espenhgn espenhgn commented Mar 27, 2025

Fixes #302

Changes proposed in this pull request:

  • adds plink2 binary, and dask, pyarrow, fastparquet to python3.sif build
  • bumps version to 1.9.1 (new release)

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant documentation and docstrings where appropriate in the codebase.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@espenhgn espenhgn added the enhancement New feature or request label Mar 27, 2025
@espenhgn espenhgn changed the title Espenhgn/issue302 python3.sif: containerize tools Mar 27, 2025
@espenhgn espenhgn requested a review from Copilot March 27, 2025 10:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the python3.sif container by adding plink2 and additional packages (dask, pyarrow, fastparquet) as well as updating the version to 1.9.1.

  • Bumps the release version by setting the version suffix to an empty string
  • Adds tests for the new plink2 binary and updates the package list in the tests
  • Updates the CHANGELOG.md to reflect the new release and added features

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
version/version.py Updates the version suffix for the release version
tests/test_python3.py Adds tests for the plink2 binary and updates package list for new dependencies
CHANGELOG.md Documents the new release version and added packages to the container
Files not reviewed (2)
  • docker/dockerfiles/python3/Dockerfile: Language not supported
  • docker/scripts/apt_get_essential.sh: Language not supported

@espenhgn espenhgn merged commit 902d15f into main Mar 27, 2025
10 checks passed
@espenhgn espenhgn deleted the espenhgn/issue302 branch March 27, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Containerize tools
1 participant