fixup: tighten inline plot comments#435
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
asmacdo
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens inline prose and docstrings around CPU envelope/derived CPU explanations while preserving the core constraint information from the larger plotting/resource-statistics work.
Changes:
- Shortens explanatory comments for plot envelope rendering and legend structure.
- Condenses
pdcpu_from_pcpudocstring while retaining Linux-only and “no measurement” caveats. - Trims byte-unit comment wording without changing the shared SI unit behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/con_duct/plot.py |
Simplifies comments describing envelope bounds and plot legends. |
src/con_duct/_utils.py |
Tightens the pdcpu_from_pcpu docstring. |
src/con_duct/_formatter.py |
Shortens the comment describing shared decimal byte units. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
==========================================
- Coverage 91.08% 90.92% -0.17%
==========================================
Files 15 15
Lines 1245 1245
Branches 170 170
==========================================
- Hits 1134 1132 -2
- Misses 77 78 +1
- Partials 34 35 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to be merged with #424 missed a push before I did.