Skip to content

[bot-automerge] awkward-cpp v41#53

Merged
matthewfeickert merged 3 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:41_h8b3d95
Nov 8, 2024
Merged

[bot-automerge] awkward-cpp v41#53
matthewfeickert merged 3 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:41_h8b3d95

Conversation

@regro-cf-autotick-bot

@regro-cf-autotick-bot regro-cf-autotick-bot commented Nov 8, 2024

Copy link
Copy Markdown
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11736587348 - please use this URL for debugging.

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

@matthewfeickert
matthewfeickert marked this pull request as draft November 8, 2024 05:52

@matthewfeickert matthewfeickert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should get postponed until after we learn if PR #52 is possible or not.

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing, but could not be merged (error=API error in PUT to merge -- 'Pull Request is still a draft').

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@matthewfeickert

Copy link
Copy Markdown
Member

@conda-forge/awkward @conda-forge/awkward-cpp We need to make a call if awkward-cpp v41 should match PyPI and be Python 3.8+ (this is what I would vote for) or if it should get the (what I assume was) intended Python required version of Python 3.9 (c.f. scikit-hep/awkward#3297).

@matthewfeickert matthewfeickert self-assigned this Nov 8, 2024
@matthewfeickert
matthewfeickert marked this pull request as ready for review November 8, 2024 09:51
@matthewfeickert

Copy link
Copy Markdown
Member

Ah, as scikit-hep/awkward#3295 made it into awkward-cpp v41 we have no choice but to diverge from PyPI and bump awkward-cpp to Python 3.9+ as https://github.com/scikit-hep/awkward/blame/b620e696e1147d6a6cf2d1070439db7d7bc77771/awkward-cpp/src/awkward_cpp/cpu_kernels.py#L7-L12 was removed and so the code requires Python 3.9+ now.

@matthewfeickert

Copy link
Copy Markdown
Member

@conda-forge-admin, please rerender

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge automerge bot!

It appears that not all commits to this PR were made by the bot. Thus this PR is not being automatically merged. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@matthewfeickert
matthewfeickert merged commit 8f9a4f0 into conda-forge:main Nov 8, 2024
@regro-cf-autotick-bot
regro-cf-autotick-bot deleted the 41_h8b3d95 branch November 8, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants