Fix GC failure of CRI plugin #1893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jul 16, 2025
docs/INSTALL.md
Outdated
|
|
||
| ``` | ||
|
|
||
| > NOTE: `root` field of `proxy_plugins` requires containerd >= v1.6.32 or v1.7.16 or v2.0.0 |
There was a problem hiding this comment.
Thanks for the review. I think this is not necessary. I've just removed this note.
AkihiroSuda
reviewed
Jul 16, 2025
README.md
Outdated
|
|
||
| # Use stargz snapshotter through CRI | ||
| [plugins."io.containerd.grpc.v1.cri".containerd] | ||
| snapshotter = "stargz" | ||
| disable_snapshot_annotations = false | ||
| ``` | ||
|
|
||
| **Note that `disable_snapshot_annotations = false` is required since containerd > v1.4.2** | ||
| > NOTE1: `disable_snapshot_annotations = false` is required since containerd > v1.4.2 |
There was a problem hiding this comment.
You can just drop this note as containerd v1.4 and older releases have already reached EOL
Signed-off-by: Kohei Tokunaga <[email protected]>
Signed-off-by: Kohei Tokunaga <[email protected]>
Signed-off-by: Kohei Tokunaga <[email protected]>
AkihiroSuda
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1349
CRI plugins fails to perform GC because it fails to find root direcotry of stargz snapshotter.
Recent containerd added
proxy_plugins.stargz.exports.rootfield to config.toml for solving this issue so this PR leverages that feature.