Add buffer validation and tests for passthrough concurrent file merging #2012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the outstanding issue discussed in this comment. The following changes are introduced:
checkHoles
methodDuring the
processBatchChunks
, we now record the starting position and the actual size of the buffer read each time. This information is then validated by thecheckHoles
method to ensure there are no gaps or overwrites in the buffer.w.Write(buffer)
We also added validation for the return value after
w.Write(buffer)
to prevent any unknown write errors.Additional test cases have been included to cover three scenarios: normal batch processing with validation, batch processing with unhandled chunks, and errors in index calculations.