wasm: add support for wasmedge runtime #774

ibmibmibm · 2021-11-08T10:42:36Z

configure.ac

src/libcrun/container.c

flouthoc · 2021-11-08T11:05:20Z

@ibmibmibm Not a blocker: but would it be possible to add a small section with cri-o as example in a small doc here https://github.com/containers/crun/tree/main/docs ?

flouthoc · 2021-11-08T11:06:27Z

@ibmibmibm Also does current implementation of wasmedge supports building a .wat in crun during runtime ?

ibmibmibm · 2021-11-08T11:07:28Z

@ibmibmibm Also does current implementation of wasmedge supports building a .wat in crun during runtime ?

No, we focus on wasm binary format only.

flouthoc

LGTM

src/libcrun/container.c

giuseppe

LGTM

src/libcrun/container.c

Signed-off-by: Shen-Ta Hsieh <[email protected]>

flouthoc · 2021-11-08T14:07:44Z

LGTM

flouthoc · 2021-11-08T14:08:04Z

@ibmibmibm Thanks for the PR 😄

giuseppe · 2021-11-08T14:40:26Z

we definitely need to get either wasmer or wasmedge into major distros like Fedora so that we can enable the feature by default :-)

rhatdan · 2021-11-08T18:47:16Z

@lsm5 @jnovy thoughts?

lsm5 · 2021-11-08T19:51:04Z

@giuseppe what's the upstream repo for wasmer / wasmedge?

giuseppe · 2021-11-09T08:44:29Z

wasmer: https://github.com/wasmerio/wasmer
wasmedge: https://github.com/WasmEdge/WasmEdge

flouthoc · 2021-11-09T09:01:55Z

I'll also confirm from wasmer maintainers if they are planning to pack and distribute if not then we can do it ourselves.

jnovy · 2021-11-09T14:49:07Z

@giuseppe does wasm/wasmedge need to be packaged separately?

giuseppe · 2021-11-09T14:56:27Z

yes, I think we need new packages for that.

I'd stick just with one now, like wasmer, to avoid wasting resources on two different backends that have the same features

TomSweeneyRedHat · 2021-11-09T22:17:31Z

@jnovy @giuseppe is this something we need for RHEL or just Fedora at this point? Looping in @fatherlinux. I'm hoping the answer is RHEL 8.5/9.1 or later....

rhatdan · 2021-11-09T22:21:41Z

Definitely later. RHEL 8.7 and 9.1 is fine with me.

juntao · 2021-11-09T23:24:51Z

I'd stick just with one now, like wasmer, to avoid wasting resources on two different backends that have the same features

Hello, I am a maintainer at WasmEdge. :)

May I suggest to have WasmEdge included as default? 😅 We can commit to maintain and support the upstream version. WasmEdge is a Linux Foundation / CNCF hosted project.

And if you are interested, here are some of the differentiating features WasmEdge has beyond WASM and WASI standards:

https://github.com/WasmEdge/WasmEdge/blob/master/docs/highlights.md

Thank you for your consideration!

flouthoc · 2021-11-10T05:03:16Z

@juntao I dont have a strong opinion on this one. But one edge with wasmer is that it supports building .wat modules on the fly. I think it will be a good advantage feature advantage for crun in long run and at this point wasmer has a huge community building and improving runtime.

But again i don't have a strong opinion on this one.

flouthoc · 2021-11-10T05:42:13Z

But I might be missing lot of other points hence looping in @syrusakbary for his opinions on this one and for ref original wasmer hook PR: #742

syrusakbary · 2021-11-10T10:09:05Z

Thanks for the chiming me in @flouthoc.
First of all, great work on adding Wasm support via Wasmer on crun... your original PR #742 is really impressive!

As far as I'm aware Wasmer is the most popular runtime among CNCF companies already (many of them already using it on production). It's quite mature (11k commits) and it supports many features that will make it ideal for being the default crun Wasm runtime. Here are some:

Support for multiple compilers (llvm, cranelift and singlepass)
Multiple engines (dylib and universal)
Pre-compiled AOT and "JIT" running modes
Headless mode (so we can ship a super slim version of Wasmer in case we want to run pre-compiled modules)
Resource limitation
WAT support
Tons of language integrations (C, Python, Go, Ruby, Zig, Rust, C#, Java, Elixir, ...)
Very strong community

Aside of that, there are many integrations of Wasmer in multiple OSS already (Gentoo, Arch Linux, ...), so I think it will be relatively easy to target new ones (RHEL, Fedora): https://repology.org/project/wasmer/versions

giuseppe · 2021-11-10T12:43:07Z

are you planning on adding wasmer (and the C bindings) to Fedora?

Until there is no package for Fedora, as well as other distros we are targeting, we won't be able to switch the support for wasmer in the crun build

rhatdan · 2021-11-10T21:00:23Z

Right we need the libraries built into fedora and eventually debian and ubuntu. Then we can turn it on by default. If it goes well we can consider it in RHEL and potentially OpenShift.

lsm5 · 2021-11-10T21:47:54Z

@syrusakbary / @juntao if you know anybody that would be interested in creating and owning the Fedora package, please send them my way. I'd be happy to review and approve both wasmer and wasmedge into Fedora assuming long term maintenance won't be on me :)

juntao · 2021-11-11T02:48:48Z

@lsm5 WasmEdge's @hydai will be responsible for creating and maintaining WasmEdge's RPM / Fedroa package. :) Please let us know the next steps.

giuseppe · 2021-11-11T08:57:21Z

@juntao a good starting point on adding a new package to Fedora is here: https://docs.fedoraproject.org/en-US/package-maintainers/New_Package_Process_for_New_Contributors/

Following PR initiates and adds support for crun to be able to build and run wasm/wasi workload in a native manner using `wasmtime`. Crun already supports running `wasm` workload using `wasmer` and `wasmedge` following PR extends this feature so that end-users can switch to `wasmtime`, following feature is proposed inorder to maintain feature parity with other tools in the same space. Ref: * Wasmedge integration: containers#774 * Wasmer integration: containers#742 Signed-off-by: Aditya R <[email protected]>

Following PR initiates and adds support for crun to be able to build and run wasm/wasi workload in a native manner using `wasmtime`. Crun already supports running `wasm` workload using `wasmer` and `wasmedge` following PR extends this feature so that end-users can switch to `wasmtime`, following feature is proposed inorder to maintain feature parity with other tools in the same space like `krustlet` which rely on `wasmtime` under the hood. Ref: * Wasmedge integration: containers#774 * Wasmer integration: containers#742 * https://github.com/krustlet/krustlet Signed-off-by: Aditya R <[email protected]>

flouthoc reviewed Nov 8, 2021

View reviewed changes

configure.ac Outdated Show resolved Hide resolved

flouthoc reviewed Nov 8, 2021

View reviewed changes

src/libcrun/container.c Outdated Show resolved Hide resolved

flouthoc reviewed Nov 8, 2021

View reviewed changes

src/libcrun/container.c Show resolved Hide resolved

ibmibmibm force-pushed the feature/wasmedge branch from 12b1773 to b68a02f Compare November 8, 2021 10:58

ibmibmibm force-pushed the feature/wasmedge branch 2 times, most recently from 5203fd6 to d697bb9 Compare November 8, 2021 11:10

flouthoc approved these changes Nov 8, 2021

View reviewed changes

giuseppe reviewed Nov 8, 2021

View reviewed changes

src/libcrun/container.c Show resolved Hide resolved

giuseppe reviewed Nov 8, 2021

View reviewed changes

src/libcrun/container.c Outdated Show resolved Hide resolved

giuseppe approved these changes Nov 8, 2021

View reviewed changes

src/libcrun/container.c Show resolved Hide resolved

wasm: add support for wasmedge runtime

825108e

Signed-off-by: Shen-Ta Hsieh <[email protected]>

ibmibmibm force-pushed the feature/wasmedge branch from d697bb9 to 825108e Compare November 8, 2021 12:47

flouthoc merged commit d78b1b6 into containers:main Nov 8, 2021

ibmibmibm deleted the feature/wasmedge branch November 9, 2021 07:50

hydai mentioned this pull request Nov 19, 2021

[CI] Enable Fedora build in GitHub actions WasmEdge/WasmEdge#663

Closed

juntao mentioned this pull request Nov 22, 2021

[Rust] Support youki WasmEdge/WasmEdge#664

Closed

flouthoc mentioned this pull request Jul 5, 2022

wasm: add support for running containers using wasmtime #963

Merged

wasm: add support for wasmedge runtime #774

wasm: add support for wasmedge runtime #774

Uh oh!

Conversation

ibmibmibm commented Nov 8, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

flouthoc commented Nov 8, 2021

Uh oh!

flouthoc commented Nov 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ibmibmibm commented Nov 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flouthoc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

giuseppe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

flouthoc commented Nov 8, 2021

Uh oh!

flouthoc commented Nov 8, 2021

Uh oh!

giuseppe commented Nov 8, 2021

Uh oh!

rhatdan commented Nov 8, 2021

Uh oh!

lsm5 commented Nov 8, 2021

Uh oh!

giuseppe commented Nov 9, 2021

Uh oh!

flouthoc commented Nov 9, 2021

Uh oh!

jnovy commented Nov 9, 2021

Uh oh!

giuseppe commented Nov 9, 2021

Uh oh!

TomSweeneyRedHat commented Nov 9, 2021

Uh oh!

rhatdan commented Nov 9, 2021

Uh oh!

juntao commented Nov 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flouthoc commented Nov 10, 2021

Uh oh!

flouthoc commented Nov 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

syrusakbary commented Nov 10, 2021

Uh oh!

giuseppe commented Nov 10, 2021

Uh oh!

rhatdan commented Nov 10, 2021

Uh oh!

lsm5 commented Nov 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juntao commented Nov 11, 2021

Uh oh!

giuseppe commented Nov 11, 2021

Uh oh!

Uh oh!

flouthoc commented Nov 8, 2021 •

edited

Loading

ibmibmibm commented Nov 8, 2021 •

edited

Loading

juntao commented Nov 9, 2021 •

edited

Loading

flouthoc commented Nov 10, 2021 •

edited

Loading

lsm5 commented Nov 10, 2021 •

edited

Loading