Balloons with components #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
force-pushed
the
5bR_balloons_composite
branch
from
a0a8e80 to
80390d6
Compare
askervin
force-pushed
the
5bR_balloons_composite
branch
from
80390d6 to
42fc185
Compare
klihub
approved these changes
Jun 12, 2025
|
@askervin This needs a rebase and conflict resolution. |
Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
askervin
force-pushed
the
5bR_balloons_composite
branch
from
42fc185 to
f0be14d
Compare
|
@klihub, rebased, conflict in doc resolved. e2e test passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series introduces composite balloons.
I'd recommend starting the review by reading the document change.
The
componentsoption may look a bit funny, because there is only one property that can be defined for each component, namelyballoonType.However, for future steps, it is important to reserve room for other properties as well. For instance, each component is likely to need a
cpuPortionto enable different portions of composite balloon's CPUs to be allocated by different component balloon types. Quite likely a property telling that a fixed number of CPUs should be allocated from a particular component, while allocation of all the other needed CPUs can be shared among other components.