Drop tools.go in favor of native tool directive support in go 1.24

[fmuyassarov]

No description provided.

[klihub]

@fmuyassarov I'm not against this at all, but could we delay this until we manage to get most of the other functional PR's merged ? We have a bit of a crunch going on ATM, so I'd prefer to focus on getting those merged first.

[fmuyassarov]

@fmuyassarov I'm not against this at all, but could we delay this until we manage to get most of the other functional PR's merged ? We have a bit of a crunch going on ATM, so I'd prefer to focus on getting those merged first.

Absolutely. You can ping me here whenever you will ready for this change. Thanks.

[klihub]

@fmuyassarov I'm not against this at all, but could we delay this until we manage to get most of the other functional PR's merged ? We have a bit of a crunch going on ATM, so I'd prefer to focus on getting those merged first.

Absolutely. You can ping me here whenever you will ready for this change. Thanks.

@fmuyassarov Then again, if those CI failures would go away by simply bumping golang to 1.24.x in go.mod, then there is no need to delay this. We can do so and merge this once it is updated.

[klihub]

@fmuyassarov I'm not against this at all, but could we delay this until we manage to get most of the other functional PR's merged ? We have a bit of a crunch going on ATM, so I'd prefer to focus on getting those merged first.

Absolutely. You can ping me here whenever you will ready for this change. Thanks.

@fmuyassarov Then again, if those CI failures would go away by simply bumping golang to 1.24.x in go.mod, then there is no need to delay this. We can do so and merge this once it is updated.

I pulled this in and it looks like the problems go away by a

go get k8s.io/client-go/tools/[email protected] && \
    go mod tidy && \
    git commit -m -s "go.{mod,sum} update and tidy deps."

After that make verify-generate verify-build verify-godeps && echo PASS passes locally.

[marquiz]

Thanks @fmuyassarov. The PR also updates the deps (especially k8s.io/code-generator). That's fine assuming you've tested that code-generation still works :) Suggestion: that could be mentioned in the commit message.

LGTM from me

[fmuyassarov]

Thanks @fmuyassarov. The PR also updates the deps (especially k8s.io/code-generator). That's fine assuming you've tested that code-generation still works :) Suggestion: that could be mentioned in the commit message.

Generate target was ran successfully. I assume it is safe to bump the generator library.

make generate
/Users/est/work/nri-plugins/build-aux/bin/controller-gen \
		crd:generateEmbeddedObjectMeta=true output:crd:artifacts:config=config/crd/bases\
		paths="./pkg/apis/..."
/Users/est/work/nri-plugins/build-aux/bin/controller-gen \
		rbac:roleName=manager-role crd paths="./pkg/apis/..." output:crd:artifacts:config=config/crd/bases
/Users/est/work/nri-plugins/build-aux/bin/controller-gen object:headerFile="scripts/hack/boilerplate.go.txt" paths="./pkg/apis/..."
./scripts/hack/update_codegen.sh go /Users/est/work/nri-plugins/build-aux
Cleaning up temporary vendor directory...
Updating Helm chart CRDs for topology-aware plugin...
Updating Helm chart CRDs for balloons plugin...
Updating Helm chart CRDs for template plugin...
No generated CRD found for memory-qos plugin...
No generated CRD found for memtierd plugin...
No generated CRD found for sgx-epc plugin...

[klihub]

Thanks @fmuyassarov. The PR also updates the deps (especially k8s.io/code-generator). That's fine assuming you've tested that code-generation still works :) Suggestion: that could be mentioned in the commit message.

Generate target was ran successfully. I assume it is safe to bump the generator library.

make generate
/Users/est/work/nri-plugins/build-aux/bin/controller-gen \
		crd:generateEmbeddedObjectMeta=true output:crd:artifacts:config=config/crd/bases\
		paths="./pkg/apis/..."
/Users/est/work/nri-plugins/build-aux/bin/controller-gen \
		rbac:roleName=manager-role crd paths="./pkg/apis/..." output:crd:artifacts:config=config/crd/bases
/Users/est/work/nri-plugins/build-aux/bin/controller-gen object:headerFile="scripts/hack/boilerplate.go.txt" paths="./pkg/apis/..."
./scripts/hack/update_codegen.sh go /Users/est/work/nri-plugins/build-aux
Cleaning up temporary vendor directory...
Updating Helm chart CRDs for topology-aware plugin...
Updating Helm chart CRDs for balloons plugin...
Updating Helm chart CRDs for template plugin...
No generated CRD found for memory-qos plugin...
No generated CRD found for memtierd plugin...
No generated CRD found for sgx-epc plugin...

Yes, there is a verify-generate target/CI job which runs that and checks that there are no changes. That having passed should mean that the generator has verbatim generated the same content as already committed to the repo, so it should be fine.