-
Notifications
You must be signed in to change notification settings - Fork 2.8k
update tests duo to CRUN#1767 to support both values #26760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
update tests duo to CRUN#1767 to support both values #26760
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: timcoding1988 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a cpu.weight check in test/apiv2/20-containers.at that needs to be changed as well.
ec7f353
to
4ab918f
Compare
c444d24
to
e26283f
Compare
d95d6ab
to
3f30af9
Compare
aed54b2
to
a4b4748
Compare
3e7be6c
to
48e8c14
Compare
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
5b6f46d
to
51db26b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you like to make a test run with the new crun to make sure both version pass please use the image id c20250812t173301z-f42f41d13
containers/automation_images#411 (comment). In fact if that passes CI we can just merge it with the image bump.
Oh and it seems your commit has the wrong author set, |
a145f05
to
58ec583
Compare
Signed-off-by: Tim Zhou <[email protected]>
58ec583
to
80a4a98
Compare
Update the
podman update container all options v2 tests
. this is a change duo to CRUN changes : containers/crun#1767we will need support both new and old values using for cpu weight calculation.
Does this PR introduce a user-facing change?