Skip to content

update tests duo to CRUN#1767 to support both values #26760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timcoding1988
Copy link
Collaborator

Update the podman update container all options v2 tests. this is a change duo to CRUN changes : containers/crun#1767
we will need support both new and old values using for cpu weight calculation.

Does this PR introduce a user-facing change?


Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Aug 6, 2025
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: timcoding1988
Once this PR has been reviewed and has the lgtm label, please assign l0rd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timcoding1988 timcoding1988 requested a review from Luap99 August 6, 2025 12:04
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a cpu.weight check in test/apiv2/20-containers.at that needs to be changed as well.

@timcoding1988 timcoding1988 marked this pull request as draft August 6, 2025 12:33
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2025
@timcoding1988 timcoding1988 requested review from Luap99 and removed request for Luap99 August 6, 2025 12:33
@timcoding1988 timcoding1988 force-pushed the feat/RUN-3333_fixing-cpu-weight-test branch 2 times, most recently from ec7f353 to 4ab918f Compare August 6, 2025 13:54
@timcoding1988 timcoding1988 requested a review from Luap99 August 6, 2025 13:55
@timcoding1988 timcoding1988 marked this pull request as ready for review August 6, 2025 13:55
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2025
@timcoding1988 timcoding1988 force-pushed the feat/RUN-3333_fixing-cpu-weight-test branch 3 times, most recently from c444d24 to e26283f Compare August 11, 2025 14:11
@timcoding1988 timcoding1988 marked this pull request as draft August 11, 2025 14:11
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2025
@timcoding1988 timcoding1988 removed the request for review from Luap99 August 11, 2025 14:11
@timcoding1988 timcoding1988 force-pushed the feat/RUN-3333_fixing-cpu-weight-test branch 4 times, most recently from d95d6ab to 3f30af9 Compare August 11, 2025 19:12
@timcoding1988 timcoding1988 marked this pull request as ready for review August 11, 2025 19:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2025
@timcoding1988 timcoding1988 force-pushed the feat/RUN-3333_fixing-cpu-weight-test branch 2 times, most recently from aed54b2 to a4b4748 Compare August 11, 2025 22:33
@timcoding1988 timcoding1988 marked this pull request as draft August 11, 2025 22:38
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2025
@timcoding1988 timcoding1988 force-pushed the feat/RUN-3333_fixing-cpu-weight-test branch 3 times, most recently from 3e7be6c to 48e8c14 Compare August 12, 2025 19:48
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@timcoding1988 timcoding1988 force-pushed the feat/RUN-3333_fixing-cpu-weight-test branch 5 times, most recently from 5b6f46d to 51db26b Compare August 13, 2025 17:20
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you like to make a test run with the new crun to make sure both version pass please use the image id c20250812t173301z-f42f41d13 containers/automation_images#411 (comment). In fact if that passes CI we can just merge it with the image bump.

@Luap99
Copy link
Member

Luap99 commented Aug 13, 2025

Oh and it seems your commit has the wrong author set, Author: shiavm006 <[email protected]>. That should be set to you of course.

@timcoding1988 timcoding1988 force-pushed the feat/RUN-3333_fixing-cpu-weight-test branch 3 times, most recently from a145f05 to 58ec583 Compare August 14, 2025 12:30
@timcoding1988 timcoding1988 requested a review from Luap99 August 14, 2025 12:32
@timcoding1988 timcoding1988 marked this pull request as ready for review August 14, 2025 12:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2025
@timcoding1988 timcoding1988 force-pushed the feat/RUN-3333_fixing-cpu-weight-test branch from 58ec583 to 80a4a98 Compare August 14, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants