Allow to use key shortcut to operate multi-cursors #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use key shortcut to operate multi-cursors. You can use:
ctrl_shift_up: add_cursor_above
ctrl_shift_down: add_cursor_below
alt_shift_up: delete_cursor_above
alt_shift_down: delete_cursor_above
If you merge this PR, I can update corresponding description for multi cursors in wiki.
Besides, I just recommend code should set "ctrl_home" and "ctrl_end" to go top and bottom of the buffer and I can use "ctrl_up" and "ctrl_down" to add cursor above/below. And I believe "ctrl_home" and "ctrl_end" are more logical.
What's more, remove 2 bugs:
1. Removed the duplicate Zsh check in quickcomment.lua and added a check for Batch.
2. Removed the multi-cursors bug when anyone of them is at the top or end. Reproduce steps:
a. Create multiple cursors and one of them is at the top or end of the doc.
b. Move cursor up or down.
c. Type sth.