Added masked loss function from 10.7.5 to Seq2Seq #2656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In 10.7, a masked loss function was added to the local
Seq2Seq
class using the decorator@d2l.add_to_class(Seq2Seq)
. However, this loss function was not added to the classd2l.Seq2Seq.
This omission leads to incorrect training and validation errors in chapter 11.In this pull request, I simply added the masked loss function to the
d2l.Seq2Seq
class.By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.