Skip to content

Remove encode conditions by using a consumer pattern #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

dampcake
Copy link
Owner

  • Simplifies logic by removing conditions as the call that was going to be made was always known ahead of time

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (843b8b4) to head (ab4d4ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main       #26      +/-   ##
=============================================
+ Coverage     99.53%   100.00%   +0.46%     
- Complexity       99       100       +1     
=============================================
  Files             7         7              
  Lines           217       210       -7     
  Branches         31        27       -4     
=============================================
- Hits            216       210       -6     
+ Partials          1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dampcake dampcake merged commit c8a6665 into main Mar 28, 2025
9 checks passed
@dampcake dampcake deleted the remove-encode-conditions branch March 28, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant