Updated all .NET quickstarts#1332
Conversation
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…dernization changes throughout .NET projects. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
… modern syntax and the latest Dapr SDK capabilities. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
alicejgibbons
left a comment
alicejgibbons
left a comment
There was a problem hiding this comment.
Just one CI error and a couple of questions :)
| value: secrets.json | ||
| - name: nestedSeparator | ||
| value: ":" | ||
| - name: secretsFile |
There was a problem hiding this comment.
CI doesn't like this file anymore @WhitWaldo, looks like a special character made it in here.
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Dapr.AspNetCore" Version="1.18.1" /> |
There was a problem hiding this comment.
Dapr.AspNetCore not needed here anymore? Would it not be better to use this than the hosting package?
There was a problem hiding this comment.
That's correct. Dapr.AspNetCore isn't being deprecated, but there is increasingly no reason to use it unless you're using legacy functionality. As quickstarts are intended to introduce ideas to new (or existing) users, I want to set users on the right course instead of starting from a not-quite-but-mostly deprecated path.
| app.MapPost("/start", async ( | ||
| string[] input, | ||
| DaprWorkflowClient workflowClient) => | ||
| [FromServices] DaprWorkflowClient workflowClient) => |
There was a problem hiding this comment.
This [FromServices] decorator is the recommended way to create all clients now?
Signed-off-by: Alice Gibbons <alicejgibbons@gmail.com>
3 participants
Description
Updated all the .NET quickstarts to use the latest 1.18.2 package.
Further, I went through all the projects to update them to use modern C# syntax and shape.
Several of the projects were also updated to specifically reflect how to implement new SDK functionality with the 1.18 release:
No operational changes to what the quickstarts do - just modernizing to reflect the latest best practices.
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: