Move remaining config option parsing to ConfigLoad() #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has several benefits: - Configuration errors are caught at startup rather than upon a connection - senderChecker() has less work to do for each connection
This has several benefits: - Configuration errors are caught at startup rather than upon a connection - recipientChecker() has less work to do for each connection
JonathonReinhart
changed the title
JonathonReinhart
changed the title
decke
reviewed
Mar 14, 2021
This has several benefits: - Configuration errors are caught at startup rather than upon a connection - mailHandler() has less work to do for each connection Rather than relying on remote_user and remote_pass to control whether authentication is used, introduce an explicit "none" type for remote_auth, and make that the default. (This is effectively the same default behavior since remote_user and remote_pass default to empty.) Also, we are in a better position to more thoroughly check for configuration errors or mismatches: - If remote_auth is given, remote_user and remote_pass are required. - If remote_auth is given, remote_host is also required (because it makes no sense to say we're going to authenticate if we have no server to which to authenticate.) - If remote_user or remote_pass are given, remote_auth cannot be "none".
JonathonReinhart
force-pushed
the
allow-any-sender-recipient
branch
from
797ad12 to
22ef0c2
Compare
decke
approved these changes
Mar 31, 2021
|
Sorry that it took me so long to come back to this but my dayjob is keeping me extremely busy these days. |
|
No worries! Thanks for Do you still want to be the one to click "Merge" after approving a PR? I'm fine with that, but just want to make sure we're on the same page with procedure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move remaining parsing of config options from server callbacks to
ConfigLoad():allowed_senderregex compilationallowed_recipientsregex compilationremote_auth,remote_user,remote_password)With this change, we can catch configuration errors during startup and avoid an error case during connection handling.
This also introduces a
nonetype forremote_auth, and makes it the default. This is a more explicit equivalent of an empty username/password before this change.This was identified during review of #13 and implementation of #15.