Allow config to have multiple remotes. #63
Conversation
|
I haven't looked closely yet, but this has some overlap with (and if accepted, might supersede) #31. |
|
Agreed, the scheme will allow TLS flow to be forced |
| @@ -375,11 +376,11 @@ func SendMail(addr string, a smtp.Auth, from string, to []string, msg []byte) er | |||
| } | |||
| } | |||
There was a problem hiding this comment.
We should check here if scheme is starttls:// but server did not announce STARTTLS extension => raise an error
There was a problem hiding this comment.
Good call, I've added the error
There was a problem hiding this comment.
This diff looks a bit strange on github (don't know why) but I will have a look at that after the merge. Thanks!
Update: was just a glitch on the github diff preview. Code is fine!
|
The change is really great, thanks a lot for your work! |
This will enable development teams to test emails from a system like mailcatcher while also having the email delivered to the indented mailbox.
|
@decke I've made the changes. Let me know if there is anything else you see. Thanks for the project, this helps us a ton with testing. |
| @@ -375,11 +376,11 @@ func SendMail(addr string, a smtp.Auth, from string, to []string, msg []byte) er | |||
| } | |||
| } | |||
There was a problem hiding this comment.
This diff looks a bit strange on github (don't know why) but I will have a look at that after the merge. Thanks!
Update: was just a glitch on the github diff preview. Code is fine!
|
Thanks a lot for your contribution! :o) |
This will enable development teams to test emails from a system like mailcatcher while also having the email delivered to the indented mailbox.