Add optional themeOptions on FocusRingScope #11
Merged
+25
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add light and dark css var and fix brightness calculation to allow these colors.
Brightness is a value from 0 to 1 and by default set to 0.2.
The prop themeOptions is optional and if undefined, Focus ring will have the same behavior as before. Otherwise, It will use light & dark theme (if saturation > 0.4).
Moreover, saturation could be part of themeOptions but I chose not to touch it.
Example :
No behavior change, it will still be primary or white ring
If the background brightness is 0.4, ring will be set to dark
If the background brightness is 0.2, ring will be set to light
Its an answer to this issue => #8