(Safe) Implementation of the token-safe retry logic for gfal #12218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
anpicci
changed the title
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
anpicci
commented
Feb 17, 2025
khurtado
force-pushed
the
dev_12144_bis
branch
from
171abae to
eea7b19
Compare
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
…eateCopyCommand and createRemoveCommand
|
@amaltaro this is ready for the final review |
|
Jenkins results:
|
|
test this please |
|
Jenkins results:
|
|
test this please |
|
Jenkins results:
|
amaltaro
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12144
Status
Tested
Description
This PR introduces the retry logic proposed by @stlammel for handling the possible failures with token authentication when used with
gfal-cpandxrootdprotocols.Both the copy and remove commands are preceded by setting the proper env variables to enforcing the desired authentication method, specified via the
authMethodmethod argument. In addition, given that these protocols will try to use every authentication method before failing, an additionalforceMethodargument is added to unset the env variables needed to enable the undesired protocol.For instance:
authMethod=TOKEN, forceMethod=Trueset theBEARER_TOKEN*env variables and clearly unset theX509_ones.These variables are introduced also for all other subclasses for the other protocols, but their usage in not implemented for now. The retry logic is delegated to
StageOutImplIs it backward compatible (if not, which system it affects?)
YES
Related PRs
#12199 for implementing the token authentication in the stage-in step
This PR overrides #12191
External dependencies / deployment changes
None