Skip to content

Merge local WM build with pypi CI/CD workflow #12281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

Merge local WM build with pypi CI/CD workflow #12281

merged 1 commit into from
Mar 5, 2025

Conversation

vkuznet
Copy link
Contributor

@vkuznet vkuznet commented Feb 26, 2025 •
edited by anpicci
Loading

Fixes #12256

Status

ready, but CI/CD workflows will only be tested by GitHub Action

Description

Merge two CI/CD workflows:

  • the one which performs local builds and installation of WM packages
  • and, the one which pushes WM packages to PyPi

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

This continuation of work which were presented in #12259

External dependencies / deployment changes

@vkuznet vkuznet added Python3 Technical Debt Used to track issues that address technical needs internal to WM team labels Feb 26, 2025
@vkuznet vkuznet self-assigned this Feb 26, 2025
@dmwm-bot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 1 new failures
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/395/artifact/artifacts/PullRequestReport.html

mapellidario
mapellidario approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@mapellidario mapellidario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks valentin!

amaltaro
amaltaro reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good in general, thanks Valentin. Nonetheless, I left a couple of comments along the code for your consideration.

.github/workflows/pypi_build_and_images.yaml Outdated
# libcurl library), etc.
- name: Update system packages to include pycurl
run: |
echo "update system packages to include pycurl dev librarty (required for pycurl)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a typo here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, resolved

@dmwm-bot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/418/artifact/artifacts/PullRequestReport.html

@vkuznet vkuznet requested a review from amaltaro March 3, 2025 14:31
amaltaro
amaltaro approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Valentin.

@amaltaro
Copy link
Contributor

amaltaro commented Mar 5, 2025

Oups, I almost missed the fact that we have 2 commits at the moment. Can you please squash those please?
If review is almost completed and there is only minor and small things to update, feel free to provide those as a final single commit in the future. @vkuznet

@vkuznet
Copy link
Contributor Author

vkuznet commented Mar 5, 2025

@amaltaro , I squashed commits. Please proceed with merge.

@dmwm-bot
Copy link

dmwm-bot commented Mar 5, 2025

Jenkins results:

  • Python3 Unit tests: succeeded
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/435/artifact/artifacts/PullRequestReport.html

@amaltaro amaltaro merged commit 5ea12ee into dmwm:master Mar 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapellidario mapellidario mapellidario approved these changes

@amaltaro amaltaro amaltaro approved these changes

Assignees

@vkuznet vkuznet

Labels
Python3 Technical Debt Used to track issues that address technical needs internal to WM team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean-up and refactor WM Core build tools
4 participants
@vkuznet @dmwm-bot @amaltaro @mapellidario