Skip to content

Migrate to from queue_with_itemdata() to Schedd.submit() #12287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

khurtado
Copy link
Contributor

@khurtado khurtado commented Mar 3, 2025

Fixes #12238

Status

Ready

Description

Replace schedd.Transaction and queue_with_itemdata() with Schedd.submitt(), since the former has been deprecated since 10.7.0

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

HTCondor python bindings

…it(), since

the former has been deprecated since 10.7.0
@dmwm-bot
Copy link

dmwm-bot commented Mar 3, 2025

Jenkins results:

  • Python3 Unit tests: succeeded
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
    • 4 warnings
    • 47 comments to review
  • Pycodestyle check: succeeded
    • 13 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/426/artifact/artifacts/PullRequestReport.html

@khurtado
Copy link
Contributor Author

khurtado commented Mar 7, 2025

Tested with this workflow on testbed:

https://cmsweb-testbed.cern.ch/reqmgr2/fetch?rid=amaltaro_TC_EL8_khurtado_tc_el8_v3_250305_184718_5423

Submission worked fine.

@khurtado khurtado requested a review from amaltaro March 7, 2025 18:13
@khurtado
Copy link
Contributor Author

khurtado commented Mar 7, 2025

@amaltaro This required a small change and I tested it with a testbed agent. All seems good.

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for testing these out.

@amaltaro amaltaro merged commit b94cab3 into dmwm:master Mar 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

queue_with_itemdata() has been deprecated since htcondor 10.7.0
3 participants