fix bug checkProxy incompatible #12403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
|
Hi @Viphava280444, I would let @amaltaro give a look at the failing tests, for the rest, everything looks fine to me. thanks! |
anpicci
approved these changes
Jul 7, 2025
|
Thank you so much @anpicci |
amaltaro
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12402
Status
ready
Description
Fixed SyntaxWarning in checkProxy.py by converting the regex pattern to use raw bytes string.
The issue was on line 132 where the pattern
b'\d{1,3}[:/]\d{2}[:/]\d{2}'was generating a SyntaxWarning because\dis not a valid escape sequence in Python strings. Changed it torb'\d{1,3}[:/]\d{2}[:/]\d{2}'to use a raw bytes string, which treats backslashes literally and preserves the intended regex pattern.This eliminates the warning while maintaining identical functionality.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
N/A - This is a standalone bug fix.
External dependencies / deployment changes